feat: expose WebAssembly trap handler binding#2012
Merged
nathanwhit merged 1 commit intoJul 13, 2026
Conversation
nathanwhit
marked this pull request as ready for review
July 1, 2026 01:26
bartlomieju
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a thin Rust binding for
v8::V8::EnableWebAssemblyTrapHandler(bool).The new
v8::V8::enable_web_assembly_trap_handler(use_v8_signal_handler)wrapper forwards through a C shim insrc/binding.cc, matching the existingV8global API binding style.Validation
cargo fmt --checkninja -C target/debug/gn_out obj/rusty_v8/binding.ocargo check -p v8currently stops on an unrelated existing bindgen constant mismatch insrc/string.rs(v8_String_WriteFlags_*vsWriteFlags_*).